From 46eeae04fc16783ec26735ed154376fce1d1420a Mon Sep 17 00:00:00 2001 From: Jerko Steiner Date: Sat, 16 Nov 2019 09:57:07 -0300 Subject: [PATCH] Use removeListener instead of off for Node 8 --- src/shared/TypedEmitter.test.ts | 4 ++-- src/shared/TypedEmitter.ts | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/shared/TypedEmitter.test.ts b/src/shared/TypedEmitter.test.ts index 4fe0eb6..a2e7a14 100644 --- a/src/shared/TypedEmitter.test.ts +++ b/src/shared/TypedEmitter.test.ts @@ -60,10 +60,10 @@ describe('TypedEmitter', () => { }) }) - describe('removeListener & off', () => { + describe('removeListener', () => { it('removes an event listener', () => { emitter.removeListener('test1', listener1) - emitter.off('test2', listener2) + emitter.removeListener('test2', listener2) emitter.emit('test1', 'value') emitter.emit('test2', 3) expect(stringMock.mock.calls).toEqual([]) diff --git a/src/shared/TypedEmitter.ts b/src/shared/TypedEmitter.ts index c0add9d..c0dd45d 100644 --- a/src/shared/TypedEmitter.ts +++ b/src/shared/TypedEmitter.ts @@ -19,7 +19,5 @@ export interface TypedEmitter { on(t: K, callback: Callback): this once(t: K, callback: Callback): this - off(t: K, callback: Callback): this - emit(t: K, value: E[K]): void }