From 0a1eabadd979759710dfa2b2f2316579036aaff6 Mon Sep 17 00:00:00 2001 From: Jerko Steiner Date: Thu, 5 Sep 2019 09:31:32 +0700 Subject: [PATCH] Add test for _-prefixed methods --- packages/jsonrpc/src/express.test.ts | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/jsonrpc/src/express.test.ts b/packages/jsonrpc/src/express.test.ts index e6d0ecd..9557a9a 100644 --- a/packages/jsonrpc/src/express.test.ts +++ b/packages/jsonrpc/src/express.test.ts @@ -57,7 +57,9 @@ describe('jsonrpc', () => { addWithContext = (ctx: IContext, a: number, b: number) => { return a + b + ctx.userId } - + _private = () => { + return 1 + } @ensureLoggedIn addWithContext2(ctx: IContext, a: number, b: number) { return Promise.resolve(a + b + ctx!.userId) @@ -214,6 +216,19 @@ describe('jsonrpc', () => { }) }) + it('cannot call private _-prefixed methods', async () => { + await request(createApp()) + .post('/myService') + .send({ + id: 123, + jsonrpc: '2.0', + method: '_private', + params: [], + }) + .expect(404) + .expect(/Method not found/) + }) + it('cannot call any other methods in objects prototype', async () => { await request(createApp()) .post('/myService')