From 401e5b481afb49ba40b87cb8dd1079824b2781a6 Mon Sep 17 00:00:00 2001
From: Jerko Steiner <jerko.steiner@gmail.com>
Date: Wed, 31 Jul 2019 00:53:19 +0800
Subject: [PATCH] Set status to 204 for notifications

---
 packages/jsonrpc/src/server.test.ts | 4 ++--
 packages/jsonrpc/src/server.ts      | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/packages/jsonrpc/src/server.test.ts b/packages/jsonrpc/src/server.test.ts
index ed1c00a..d0a4c6a 100644
--- a/packages/jsonrpc/src/server.test.ts
+++ b/packages/jsonrpc/src/server.test.ts
@@ -165,7 +165,7 @@ describe('jsonrpc', () => {
         method: 'add',
         params: [1, 2],
       })
-      .expect(200)
+      .expect(204)
       .expect('')
 
       await request(createApp())
@@ -176,7 +176,7 @@ describe('jsonrpc', () => {
         method: 'add',
         params: [1, 2],
       })
-      .expect(200)
+      .expect(204)
       .expect('')
     })
   })
diff --git a/packages/jsonrpc/src/server.ts b/packages/jsonrpc/src/server.ts
index 128bff3..89f005f 100644
--- a/packages/jsonrpc/src/server.ts
+++ b/packages/jsonrpc/src/server.ts
@@ -141,7 +141,7 @@ export function jsonrpc<T, F extends FunctionPropertyNames<T>>(
 
     if (!isPromise(retValue)) {
       if (isNotification) {
-        return res.send()
+        return res.status(204).send()
       }
       return res.json(createSuccessResponse(id, retValue))
     }