From 4f533e7fff0e22771f1c33219bef45737e661489 Mon Sep 17 00:00:00 2001
From: Jerko Steiner <jerko.steiner@gmail.com>
Date: Sat, 7 Sep 2019 09:44:00 +0700
Subject: [PATCH] Return headers from login/registerAccount test methods

---
 packages/server/src/routes/AuthRoutes.test.ts |  6 ++----
 packages/server/src/routes/UserRoutes.test.ts |  6 ++----
 packages/server/src/rpc/UserService.test.ts   |  7 +------
 packages/server/src/team/TeamRoutes.test.ts   |  6 +-----
 packages/server/src/test-utils/TestUtils.ts   | 12 ++++++++----
 5 files changed, 14 insertions(+), 23 deletions(-)

diff --git a/packages/server/src/routes/AuthRoutes.test.ts b/packages/server/src/routes/AuthRoutes.test.ts
index d445477..6f3177e 100644
--- a/packages/server/src/routes/AuthRoutes.test.ts
+++ b/packages/server/src/routes/AuthRoutes.test.ts
@@ -26,9 +26,7 @@ describe('/auth', () => {
     const t = test.request('/api')
     beforeEach(async () => {
       const session = await test.registerAccount()
-      const token = session.token
-      const cookie = session.cookie
-      t.setHeaders({cookie, 'x-csrf-token': token})
+      t.setHeaders(session.headers)
     })
 
     it('should prevent access when user not logged in', async () => {
@@ -64,7 +62,7 @@ describe('/auth', () => {
     let cookie!: string
     beforeEach(async () => {
       await test.registerAccount()
-      cookie = (await test.login()).cookie
+      cookie = (await test.login()).headers.cookie
     })
 
     it('should log out the user', async () => {
diff --git a/packages/server/src/routes/UserRoutes.test.ts b/packages/server/src/routes/UserRoutes.test.ts
index 44311da..3eab4c2 100644
--- a/packages/server/src/routes/UserRoutes.test.ts
+++ b/packages/server/src/routes/UserRoutes.test.ts
@@ -6,13 +6,11 @@ describe('user', () => {
   const t = test.request('/api')
 
   let cookie!: string
-  let token!: string
   beforeEach(async () => {
     await test.registerAccount()
     const session = await test.login()
-    cookie = session.cookie
-    token = session.token
-    t.setHeaders({ cookie, 'x-csrf-token': token })
+    cookie = session.headers.cookie
+    t.setHeaders(session.headers)
   })
 
   describe('GET /users/profile', () => {
diff --git a/packages/server/src/rpc/UserService.test.ts b/packages/server/src/rpc/UserService.test.ts
index 496aed6..59f720f 100644
--- a/packages/server/src/rpc/UserService.test.ts
+++ b/packages/server/src/rpc/UserService.test.ts
@@ -5,15 +5,10 @@ describe('user', () => {
 
   test.withDatabase()
 
-  let cookie!: string
-  let token!: string
   let headers: Record<string, string> = {}
   beforeEach(async () => {
     await test.registerAccount()
-    const session = await test.login()
-    cookie = session.cookie
-    token = session.token
-    headers = {cookie, 'x-csrf-token': token}
+    headers = (await test.login()).headers
   })
 
   const createService = () => {
diff --git a/packages/server/src/team/TeamRoutes.test.ts b/packages/server/src/team/TeamRoutes.test.ts
index dcfb43b..218db48 100644
--- a/packages/server/src/team/TeamRoutes.test.ts
+++ b/packages/server/src/team/TeamRoutes.test.ts
@@ -6,15 +6,11 @@ describe('team', () => {
   test.withDatabase()
   const t = test.request('/api')
 
-  let cookie!: string
-  let token!: string
   let mainUserId: number
   beforeEach(async () => {
     const session = await test.registerAccount()
-    cookie = session.cookie
-    token = session.token
     mainUserId = session.userId
-    t.setHeaders({ cookie, 'x-csrf-token': token })
+    t.setHeaders(session.headers)
   })
 
   describe('POST /teams', () => {
diff --git a/packages/server/src/test-utils/TestUtils.ts b/packages/server/src/test-utils/TestUtils.ts
index 8979694..82b88c4 100644
--- a/packages/server/src/test-utils/TestUtils.ts
+++ b/packages/server/src/test-utils/TestUtils.ts
@@ -133,9 +133,11 @@ export class TestUtils<T extends IRoutes> {
     const cookies = this.getCookies(response.header['set-cookie'])
 
     return {
-      cookie: [cookies, cookie].join('; '),
+      headers: {
+        "cookie": [cookies, cookie].join('; '),
+        'x-csrf-token': token,
+      },
       userId: response.body.id,
-      token,
     }
   }
 
@@ -152,8 +154,10 @@ export class TestUtils<T extends IRoutes> {
     const cookies = this.getCookies(response.header['set-cookie'])
 
     return {
-      cookie: [cookies, cookie].join('; '),
-      token,
+      headers: {
+        "cookie": [cookies, cookie].join('; '),
+        'x-csrf-token': token,
+      },
     }
   }