rondomoon/peer-calls
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use removeListener instead of off for Node 8

Browse Source
This commit is contained in:
Jerko Steiner 2019-11-16 09:57:07 -03:00
parent e90c8c53f6
commit 46eeae04fc
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/shared/TypedEmitter.test.ts
View File

@ -60,10 +60,10 @@ describe('TypedEmitter', () => {
}) })
}) })
describe('removeListener & off', () => { describe('removeListener', () => {
it('removes an event listener', () => { it('removes an event listener', () => {
emitter.removeListener('test1', listener1) emitter.removeListener('test1', listener1)
emitter.off('test2', listener2) emitter.removeListener('test2', listener2)
emitter.emit('test1', 'value') emitter.emit('test1', 'value')
emitter.emit('test2', 3) emitter.emit('test2', 3)
expect(stringMock.mock.calls).toEqual([]) expect(stringMock.mock.calls).toEqual([])

2
src/shared/TypedEmitter.ts
View File

@ -19,7 +19,5 @@ export interface TypedEmitter<E extends Events> {
on<K extends keyof E>(t: K, callback: Callback<E[K]>): this on<K extends keyof E>(t: K, callback: Callback<E[K]>): this
once<K extends keyof E>(t: K, callback: Callback<E[K]>): this once<K extends keyof E>(t: K, callback: Callback<E[K]>): this
off<K extends keyof E>(t: K, callback: Callback<E[K]>): this
emit<K extends keyof E>(t: K, value: E[K]): void emit<K extends keyof E>(t: K, value: E[K]): void
} }