rondomoon/rondo-framework
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set status to 204 for notifications

Browse Source
This commit is contained in:
Jerko Steiner 2019-07-31 00:53:19 +08:00
parent e16edd5655
commit 401e5b481a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/jsonrpc/src/server.test.ts
View File

@ -165,7 +165,7 @@ describe('jsonrpc', () => {
method: 'add',
params: [1, 2],
})
.expect(200)
.expect(204)
.expect('')
await request(createApp())
@ -176,7 +176,7 @@ describe('jsonrpc', () => {
method: 'add',
params: [1, 2],
})
.expect(200)
.expect(204)
.expect('')
})
})

2
packages/jsonrpc/src/server.ts
View File

@ -141,7 +141,7 @@ export function jsonrpc<T, F extends FunctionPropertyNames<T>>(
if (!isPromise(retValue)) {
if (isNotification) {
return res.send()
return res.status(204).send()
}
return res.json(createSuccessResponse(id, retValue))
}